fix: escape input before returning #4810
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete .github/workflows/security-monitoring.yml
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -106,4 +106,4 @@ | |||
|
|
|||
| return response | |||
| except Exception as e: | |||
| return f"Error during model invocation: {str(e)} for input: {request.get_data()}" | |||
| return f"Error during model invocation: {str(e)} for input: {escape(request.get_data())}" | |||
Check warning
Code scanning / CodeQL
Information exposure through an exception
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
| config_value, | ||
| source_value, | ||
| config_value_log_copy, | ||
| source_value_log_copy, |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
| config_value, | ||
| source_value, | ||
| config_value_log_copy, | ||
| source_value_log_copy, |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
* Follow-ups fixes * Refactoring * Unit tests * refactoring * Refactoring * Refactoring --------- Co-authored-by: Jonathan Makunga <[email protected]>
…ated regression (#4798) Co-authored-by: Malav Shastri <[email protected]> Co-authored-by: sage-maker <[email protected]>
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mohamedzeidan2021
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixing the potential cross site scripting vulnerability by escaping the input using flasks
escapefunction before returning the request data in the case that the request fails.Testing done:
The code scanning vulnerability disappeared in my fork once the fix was implemented.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.